diff --git a/composer.json b/composer.json index 4357c49..7efcaf8 100644 --- a/composer.json +++ b/composer.json @@ -32,13 +32,13 @@ "phplint", "phpcs" ], - "static": [ + "analyze": [ "@analyze-phpstan", "@analyze-psalm", "@analyze-rector" ], "analyze-phpstan":"vendor/bin/phpstan analyze --error-format=raw", - "analyze-psalm": "vendor/bin/psalm --no-cache", + "analyze-psalm": "vendor/bin/psalm --no-cache --show-info=true", "analyze-rector": "vendor/bin/rector --dry-run", "html": [ "pandoc -s README.md -o output/README.html", @@ -49,7 +49,7 @@ "@document", "@benchmark", "@lint", - "@static", + "@analyze", "@html" ] } diff --git a/tests/FactorGraphs/ScheduleStepTest.php b/tests/FactorGraphs/ScheduleStepTest.php index d5865b1..4e57059 100644 --- a/tests/FactorGraphs/ScheduleStepTest.php +++ b/tests/FactorGraphs/ScheduleStepTest.php @@ -10,7 +10,7 @@ use PHPUnit\Framework\TestCase; class ScheduleStepTest extends TestCase { - public function test(): void + public function testtoStringInterface(): void { $stub = $this->createStub(Factor::class); $ss = new ScheduleStep('dummy', $stub, 0); diff --git a/tests/FactorGraphs/VariableTest.php b/tests/FactorGraphs/VariableTest.php index 1cef70f..88e997b 100644 --- a/tests/FactorGraphs/VariableTest.php +++ b/tests/FactorGraphs/VariableTest.php @@ -10,7 +10,7 @@ use PHPUnit\Framework\TestCase; class VariableTest extends TestCase { - public function test(): void + public function testGetterSetter(): void { $gd_prior = new GaussianDistribution(); $var = new Variable('dummy', $gd_prior); diff --git a/tests/PlayerTest.php b/tests/PlayerTest.php index 2792e1e..675523a 100644 --- a/tests/PlayerTest.php +++ b/tests/PlayerTest.php @@ -9,10 +9,11 @@ use PHPUnit\Framework\TestCase; class PlayerTest extends TestCase { - public function test(): void + public function testPlayerObjectGetterSetter(): void { $p = new Player('dummy', 0.1, 0.2); $this->assertEquals('dummy', (string)$p); + $this->assertEquals('dummy', $p->getId()); $this->assertEquals(0.1, $p->getPartialPlayPercentage()); $this->assertEquals(0.2, $p->getPartialUpdatePercentage()); } diff --git a/tests/TrueSkill/TwoPlayerTrueSkillCalculatorTest.php b/tests/TrueSkill/TwoPlayerTrueSkillCalculatorTest.php index e1e5c2a..4ced858 100644 --- a/tests/TrueSkill/TwoPlayerTrueSkillCalculatorTest.php +++ b/tests/TrueSkill/TwoPlayerTrueSkillCalculatorTest.php @@ -17,7 +17,6 @@ class TwoPlayerTrueSkillCalculatorTest extends TestCase { $calculator = new TwoPlayerTrueSkillCalculator(); - // We only support two players TrueSkillCalculatorTests::testAllTwoPlayerScenarios($this, $calculator); } } diff --git a/tests/TrueSkill/TwoTeamTrueSkillCalculatorTest.php b/tests/TrueSkill/TwoTeamTrueSkillCalculatorTest.php index c2b53b9..9442e47 100644 --- a/tests/TrueSkill/TwoTeamTrueSkillCalculatorTest.php +++ b/tests/TrueSkill/TwoTeamTrueSkillCalculatorTest.php @@ -9,7 +9,7 @@ use PHPUnit\Framework\TestCase; use PHPUnit\Framework\Attributes\CoversClass; use PHPUnit\Framework\Attributes\CoversNothing; -//#[CoversClass(TwoTeamTrueSkillCalculator::class)] +#[CoversClass(TwoTeamTrueSkillCalculator::class)] class TwoTeamTrueSkillCalculatorTest extends TestCase { #[CoversNothing] @@ -17,7 +17,6 @@ class TwoTeamTrueSkillCalculatorTest extends TestCase { $calculator = new TwoTeamTrueSkillCalculator(); - // We only support two players TrueSkillCalculatorTests::testAllTwoPlayerScenarios($this, $calculator); TrueSkillCalculatorTests::testAllTwoTeamScenarios($this, $calculator); }