jct/trueskill
1
0
Fork 0
mirror of https://github.com/furyfire/trueskill.git synced 2025-11-04 02:02:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rector: codeQuality

Browse Source
This commit is contained in:
Jens True
2024-02-21 13:40:20 +00:00
parent 703372fda9
commit f3e5912ebb
5 changed files with 19 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Numerics/Matrix.php
View File

@@ -88,7 +88,7 @@ class Matrix
private function isSquare(): bool
{
return ($this->rowCount == $this->columnCount) && ($this->rowCount > 0);
return ($this->rowCount === $this->columnCount) && ($this->rowCount > 0);
}
public function getDeterminant(): float
@@ -208,7 +208,7 @@ class Matrix
public static function add(Matrix $left, Matrix $right): Matrix
{
if (($left->getRowCount() != $right->getRowCount()) || ($left->getColumnCount() != $right->getColumnCount())) {
if (($left->getRowCount() !== $right->getRowCount()) || ($left->getColumnCount() !== $right->getColumnCount())) {
throw new Exception('Matrices must be of the same size');
}
@@ -233,7 +233,7 @@ class Matrix
// Just your standard matrix multiplication.
// See http://en.wikipedia.org/wiki/Matrix_multiplication for details
if ($left->getColumnCount() != $right->getRowCount()) {
if ($left->getColumnCount() !== $right->getRowCount()) {
throw new Exception('The width of the left matrix must match the height of the right matrix');
}
@@ -308,7 +308,7 @@ class Matrix
public function equals(Matrix $otherMatrix): bool
{
if (($this->rowCount != $otherMatrix->getRowCount()) || ($this->columnCount != $otherMatrix->getColumnCount())) {
if (($this->rowCount !== $otherMatrix->getRowCount()) || ($this->columnCount !== $otherMatrix->getColumnCount())) {
return FALSE;
}

10
src/TrueSkill/Factors/GaussianWeightedSumFactor.php
View File

@@ -131,9 +131,11 @@ class GaussianWeightedSumFactor extends GaussianFactor
$messages = $this->getMessages();
$result = 0.0;
// We start at 1 since offset 0 has the sum
$counter = count($vars);
// We start at 1 since offset 0 has the sum
for ($i = 1; $i < count($vars); $i++) {
for ($i = 1; $i < $counter; $i++) {
$result += GaussianDistribution::logRatioNormalization($vars[$i]->getValue(), $messages[$i]->getValue());
}
@@ -211,11 +213,15 @@ class GaussianWeightedSumFactor extends GaussianFactor
$updatedVariables = [];
$indicesToUse = $this->variableIndexOrdersForWeights[$messageIndex];
// The tricky part here is that we have to put the messages and variables in the same
// order as the weights. Thankfully, the weights and messages share the same index numbers,
// so we just need to make sure they're consistent
$counter = count($allMessages);
// The tricky part here is that we have to put the messages and variables in the same
// order as the weights. Thankfully, the weights and messages share the same index numbers,
// so we just need to make sure they're consistent
for ($i = 0; $i < count($allMessages); $i++) {
for ($i = 0; $i < $counter; $i++) {
$updatedMessages[] = $allMessages[$indicesToUse[$i]];
$updatedVariables[] = $allVariables[$indicesToUse[$i]];
}