From e56fa53348c9b7667837e3762b06c8851e0f597a Mon Sep 17 00:00:00 2001 From: Jeff Moser Date: Sat, 2 Oct 2010 22:02:42 -0400 Subject: [PATCH] First time ratings were correct for the first test! (Probability of ranking needs some work of course) --- PHPSkills/TrueSkill/FactorGraphTrueSkillCalculator.php | 2 +- PHPSkills/TrueSkill/Factors/GaussianWeightedSumFactor.php | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/PHPSkills/TrueSkill/FactorGraphTrueSkillCalculator.php b/PHPSkills/TrueSkill/FactorGraphTrueSkillCalculator.php index 55ddcbc..34124a2 100644 --- a/PHPSkills/TrueSkill/FactorGraphTrueSkillCalculator.php +++ b/PHPSkills/TrueSkill/FactorGraphTrueSkillCalculator.php @@ -56,7 +56,7 @@ class FactorGraphTrueSkillCalculator extends SkillCalculator $test = $factorGraph->getUpdatedRatings(); // DEBUG: Fix this :) - //$probabilityOfOutcome = $factorGraph->getProbabilityOfRanking(); + $probabilityOfOutcome = $factorGraph->getProbabilityOfRanking(); return $factorGraph->getUpdatedRatings(); } diff --git a/PHPSkills/TrueSkill/Factors/GaussianWeightedSumFactor.php b/PHPSkills/TrueSkill/Factors/GaussianWeightedSumFactor.php index 3278a6b..23d9d21 100644 --- a/PHPSkills/TrueSkill/Factors/GaussianWeightedSumFactor.php +++ b/PHPSkills/TrueSkill/Factors/GaussianWeightedSumFactor.php @@ -152,7 +152,6 @@ class GaussianWeightedSumFactor extends GaussianFactor // Potentially look at http://mathworld.wolfram.com/NormalSumDistribution.html for clues as // to what it's doing - $messages = &$this->getMessages(); $message0 = clone $messages[0]->getValue(); $marginal0 = clone $variables[0]->getValue();