jct/trueskill
1
0
Fork 0
mirror of https://github.com/furyfire/trueskill.git synced 2025-04-19 20:34:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sub 200 warnings on static analysis

Browse Source
This commit is contained in:
Jens True
2023-08-01 12:43:58 +00:00
parent b7322362bd
commit dc35035c3c
9 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/TrueSkill/Factors/GaussianLikelihoodFactor.php
View File

@ -25,7 +25,7 @@ class GaussianLikelihoodFactor extends GaussianFactor
$this->createVariableToMessageBinding($variable2);
}
public function getLogNormalization()
public function getLogNormalization(): float
{
/** @var KeyedVariable[]|mixed $vars */
$vars = $this->getVariables();

4
src/TrueSkill/Factors/GaussianPriorFactor.php
View File

@ -15,7 +15,7 @@ class GaussianPriorFactor extends GaussianFactor
{
private $_newMessage;
public function __construct($mean, $variance, Variable $variable)
public function __construct(float $mean, float $variance, Variable $variable)
{
parent::__construct(sprintf('Prior value going to %s', $variable));
$this->_newMessage = new GaussianDistribution($mean, sqrt($variance));
@ -25,7 +25,7 @@ class GaussianPriorFactor extends GaussianFactor
$this->createVariableToMessageBindingWithMessage($variable, $newMessage);
}
protected function updateMessageVariable(Message $message, Variable $variable)
protected function updateMessageVariable(Message $message, Variable $variable): float
{
$oldMarginal = clone $variable->getValue();
$oldMessage = $message;

4
src/TrueSkill/Factors/GaussianWeightedSumFactor.php
View File

@ -127,7 +127,7 @@ class GaussianWeightedSumFactor extends GaussianFactor
return $result;
}
private function updateHelper(array $weights, array $weightsSquared, array $messages, array $variables)
private function updateHelper(array $weights, array $weightsSquared, array $messages, array $variables): float
{
// Potentially look at http://mathworld.wolfram.com/NormalSumDistribution.html for clues as
// to what it's doing
@ -182,7 +182,7 @@ class GaussianWeightedSumFactor extends GaussianFactor
return $finalDiff;
}
public function updateMessageIndex($messageIndex)
public function updateMessageIndex(int $messageIndex): float
{
$allMessages = $this->getMessages();
$allVariables = $this->getVariables();