Bunch of generic code standard items. Will need a cleanup.

.phpcs.xml

@@ -13,6 +13,31 @@
     <rule ref="PSR2"></rule>
     <rule ref="PSR12"></rule>
 
+    <rule ref="Generic">
+        <exclude name="Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed"/>
+        <exclude name="Generic.Files.LowercasedFilename.NotFound"/>
+        <exclude name="Generic.PHP.ClosingPHPTag.NotFound"/>
+        <exclude name="Generic.Files.EndFileNoNewline.Found"/>
+        <exclude name="Generic.Files.EndFileNoNewline.Found"/>
+        <exclude name="Generic.Arrays.DisallowShortArraySyntax.Found"/>
+        <exclude name="Generic.Functions.OpeningFunctionBraceKernighanRitchie.BraceOnNewLine"/>
+        <exclude name="Generic.Classes.OpeningBraceSameLine.BraceOnNewLine"/>
+        <exclude name="Generic.PHP.LowerCaseConstant.Found"/>
+        <exclude name="Generic.Formatting.SpaceAfterCast"/>
+        <exclude name="Generic.Formatting.MultipleStatementAlignment.NotSameWarning"/>
+        <exclude name="Generic.Commenting.DocComment.MissingShort"/>
+        <exclude name="Generic.NamingConventions.AbstractClassNamePrefix.Missing"/>
+        <exclude name="Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed"/>
+        <exclude name="Generic.NamingConventions.InterfaceNameSuffix.Missing"/>
+        <exclude name="Generic.Commenting.Todo.TaskFound"/>
+        <exclude name="Generic.CodeAnalysis.UnusedFunctionParameter.FoundInImplementedInterfaceAfterLastUse"/>
+        <exclude name="Generic.CodeAnalysis.UnusedFunctionParameter.FoundInExtendedClassAfterLastUsed"/>
+        <exclude name="Generic.CodeAnalysis.UnusedFunctionParameter.FoundInImplementedInterfaceAfterLastUsed"/>
+        <exclude name="Generic.Formatting.SpaceBeforeCast.NoSpace"/>
+        <exclude name="Generic.CodeAnalysis.UselessOverridingMethod.Found"/>
+        <exclude name="Squiz.Functions.MultiLineFunctionDeclaration.NewlineBeforeOpenBrace"/>
+    </rule>
+
     <!-- Ban some functions -->
     <rule ref="Generic.PHP.ForbiddenFunctions">
         <properties>

src/FactorGraphs/FactorGraph.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\FactorGraphs;
 
 class FactorGraph

src/FactorGraphs/KeyedVariable.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\FactorGraphs;
 
 class KeyedVariable extends Variable

src/FactorGraphs/Message.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\FactorGraphs;
 
 use DNW\Skills\Numerics\GaussianDistribution;

src/FactorGraphs/Schedule.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\FactorGraphs;
 
 abstract class Schedule implements \Stringable

src/Guard.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 use Exception;

src/HashMap.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 /**

src/ISupportPartialPlay.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 /**

src/ISupportPartialUpdate.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 interface ISupportPartialUpdate

src/Numerics/BasicMath.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\Numerics;
 
 /**
@@ -13,7 +15,8 @@ class BasicMath
     /**
      * Squares the input (x^2 = x * x)
      *
-     * @param  float $x Value to square (x)
+     * @param float $x Value to square (x)
+     *
      * @return float The squared value (x^2)
      */
     public static function square($x): float
@@ -24,8 +27,9 @@ class BasicMath
     /**
      * Sums the items in $itemsToSum
      *
-     * @param  mixed[]    $itemsToSum The items to sum,
+     * @param mixed[]    $itemsToSum The items to sum,
-     * @param  \Closure $callback   The function to apply to each array element before summing.
+     * @param \Closure $callback   The function to apply to each array element before summing.
+     *
      * @return float The sum.
      */
     public static function sum(array $itemsToSum, \Closure $callback): float

src/Numerics/GaussianDistribution.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\Numerics;
 
 /**
@@ -198,7 +200,8 @@ class GaussianDistribution implements \Stringable
             -1.523e-15,
             -9.4e-17,
             1.21e-16,
-            -2.8e-17, ];
+            -2.8e-17,
+        ];
 
         $ncof = count($coefficients);
         $d = 0.0;

src/Numerics/IdentityMatrix.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\Numerics;
 
 class IdentityMatrix extends DiagonalMatrix

src/Numerics/Range.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\Numerics;
 
 // The whole purpose of this class is to make the code for the SkillCalculator(s)

src/Numerics/SquareMatrix.php

@@ -1,12 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\Numerics;
 
 class SquareMatrix extends Matrix
 {
     public function __construct(float|int ...$allValues)
     {
-        $rows = (int) sqrt(count($allValues));
+        $rows = (int)sqrt(count($allValues));
         $cols = $rows;
 
         $matrixData = [];

src/Numerics/Vector.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\Numerics;
 
 class Vector extends Matrix

src/PairwiseComparison.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 /**

src/PartialPlay.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 class PartialPlay

src/Player.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 /**
@@ -26,7 +28,8 @@ class Player implements ISupportPartialPlay, ISupportPartialUpdate, \Stringable
         private mixed $Id,
         float $partialPlayPercentage = self::DEFAULT_PARTIAL_PLAY_PERCENTAGE,
         float $partialUpdatePercentage = self::DEFAULT_PARTIAL_UPDATE_PERCENTAGE
-    ) {
+    )
+    {
         // If they don't want to give a player an id, that's ok...
         Guard::argumentInRangeInclusive($partialPlayPercentage, 0.0, 1.0, 'partialPlayPercentage');
         Guard::argumentInRangeInclusive($partialUpdatePercentage, 0, 1.0, 'partialUpdatePercentage');
@@ -60,6 +63,6 @@ class Player implements ISupportPartialPlay, ISupportPartialUpdate, \Stringable
 
     public function __toString(): string
     {
-        return (string) $this->Id;
+        return (string)$this->Id;
     }
 }

src/PlayersRange.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 use DNW\Skills\Numerics\Range;

src/Rating.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 // Container for a player's rating.

src/RatingContainer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 class RatingContainer

src/SkillCalculator.php

@@ -37,8 +37,8 @@ abstract class SkillCalculator
     /**
      * Calculates the match quality as the likelihood of all teams drawing.
      *
-     * @param  GameInfo $gameInfo Parameters for the game.
+     * @param GameInfo $gameInfo Parameters for the game.
-     * @param  Team[]   $teams    A mapping of team players and their ratings.
+     * @param Team[]   $teams    A mapping of team players and their ratings.
      *
      * @return float The quality of the match between the teams as a percentage (0% = bad, 100% = well matched).
      */

src/SkillCalculatorSupportedOptions.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 class SkillCalculatorSupportedOptions

src/Team.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills;
 
 class Team extends RatingContainer

src/TrueSkill/FactorGraphTrueSkillCalculator.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\TrueSkill;
 
 use DNW\Skills\GameInfo;
@@ -34,7 +36,8 @@ class FactorGraphTrueSkillCalculator extends SkillCalculator
         GameInfo $gameInfo,
         array $teams,
         array $teamRanks
-    ): RatingContainer {
+    ): RatingContainer
+    {
         Guard::argumentNotNull($gameInfo, 'gameInfo');
         $this->validateTeamCountAndPlayersCountPerTeam($teams);
 
@@ -124,7 +127,9 @@ class FactorGraphTrueSkillCalculator extends SkillCalculator
 
     /**
      * Helper function that gets a list of values for all player ratings
+     *
      * @param Team[] $teamAssignmentsList
+     *
      * @return int[]
      */
     private static function getPlayerRatingValues(array $teamAssignmentsList, \Closure $playerRatingFunction): array

src/TrueSkill/Factors/GaussianFactor.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\TrueSkill\Factors;
 
 use DNW\Skills\FactorGraphs\Factor;

src/TrueSkill/Factors/GaussianGreaterThanFactor.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\TrueSkill\Factors;
 
 use DNW\Skills\FactorGraphs\Message;
@@ -62,11 +64,9 @@ class GaussianGreaterThanFactor extends GaussianFactor
         $denom = 1.0 - TruncatedGaussianCorrectionFunctions::wExceedsMargin($dOnSqrtC, $epsilsonTimesSqrtC);
 
         $newPrecision = $c / $denom;
-        $newPrecisionMean = (
+        $newPrecisionMean = ($d +
-                $d +
                 $sqrtC *
-                TruncatedGaussianCorrectionFunctions::vExceedsMargin($dOnSqrtC, $epsilsonTimesSqrtC)
+                TruncatedGaussianCorrectionFunctions::vExceedsMargin($dOnSqrtC, $epsilsonTimesSqrtC)) / $denom;
-            ) / $denom;
 
         $newMarginal = GaussianDistribution::fromPrecisionMean($newPrecisionMean, $newPrecision);
 

src/TrueSkill/Factors/GaussianLikelihoodFactor.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\TrueSkill\Factors;
 
 use DNW\Skills\FactorGraphs\KeyedVariable;

src/TrueSkill/Factors/GaussianPriorFactor.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\TrueSkill\Factors;
 
 use DNW\Skills\FactorGraphs\Message;

src/TrueSkill/Factors/GaussianWeightedSumFactor.php

@@ -26,6 +26,7 @@ class GaussianWeightedSumFactor extends GaussianFactor
     /**
      * This following is used for convenience, for example, the first entry is [0, 1, 2]
      * corresponding to v[0] = a1*v[1] + a2*v[2]
+     *
      * @var array<float[]> $weights
      */
     private array $weights = [];
@@ -249,7 +250,7 @@ class GaussianWeightedSumFactor extends GaussianFactor
             $absValue = sprintf('%.2f', \abs($weights[$i])); // 0.00?
             $result .= $absValue;
             $result .= '*[';
-            $result .= (string) $variablesToSum[$i];
+            $result .= (string)$variablesToSum[$i];
             $result .= ']';
 
             $isLast = ($i === $totalVars - 1);

src/TrueSkill/Factors/GaussianWithinFactor.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\TrueSkill\Factors;
 
 use DNW\Skills\FactorGraphs\Message;
@@ -65,8 +67,7 @@ class GaussianWithinFactor extends GaussianFactor
         $newPrecision = $c / $denominator;
         $newPrecisionMean = ($d +
                                 $sqrtC *
-                                TruncatedGaussianCorrectionFunctions::vWithinMargin($dOnSqrtC, $epsilonTimesSqrtC)
+                                TruncatedGaussianCorrectionFunctions::vWithinMargin($dOnSqrtC, $epsilonTimesSqrtC)) / $denominator;
-                            ) / $denominator;
 
         $newMarginal = GaussianDistribution::fromPrecisionMean($newPrecisionMean, $newPrecision);
         $newMessage = GaussianDistribution::divide(

src/TrueSkill/Layers/IteratedTeamDifferencesInnerLayer.php

@@ -17,7 +17,8 @@ class IteratedTeamDifferencesInnerLayer extends TrueSkillFactorGraphLayer
         TrueSkillFactorGraph $parentGraph,
         private readonly TeamPerformancesToTeamPerformanceDifferencesLayer $TeamPerformancesToTeamPerformanceDifferencesLayer,
         private readonly TeamDifferencesComparisonLayer $TeamDifferencesComparisonLayer
-    ) {
+    )
+    {
         parent::__construct($parentGraph);
     }
 

src/TrueSkill/Layers/TeamPerformancesToTeamPerformanceDifferencesLayer.php

@@ -32,7 +32,8 @@ class TeamPerformancesToTeamPerformanceDifferencesLayer extends TrueSkillFactorG
         Variable $strongerTeam,
         Variable $weakerTeam,
         Variable $output
-    ): GaussianWeightedSumFactor {
+    ): GaussianWeightedSumFactor
+    {
         $teams = [$strongerTeam, $weakerTeam];
         $weights = [1.0, -1.0];
 

src/TrueSkill/Layers/TrueSkillFactorGraphLayer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace DNW\Skills\TrueSkill\Layers;
 
 use DNW\Skills\FactorGraphs\FactorGraphLayer;

src/TrueSkill/TrueSkillFactorGraph.php

@@ -31,9 +31,9 @@ class TrueSkillFactorGraph extends FactorGraph
     private PlayerPriorValuesToSkillsLayer $priorLayer;
 
     /**
-     * @param  GameInfo $gameInfo  Parameters for the game.
+     * @param GameInfo $gameInfo  Parameters for the game.
-     * @param  Team[]   $teams     A mapping of team players and their ratings.
+     * @param Team[]   $teams     A mapping of team players and their ratings.
-     * @param  int[]    $teamRanks The ranks of the teams where 1 is first place. For a tie, repeat the number (e.g. 1, 2, 2).
+     * @param int[]    $teamRanks The ranks of the teams where 1 is first place. For a tie, repeat the number (e.g. 1, 2, 2).
      */
     public function __construct(private readonly GameInfo $gameInfo, array $teams, array $teamRanks)
     {

src/TrueSkill/TruncatedGaussianCorrectionFunctions.php

@@ -122,8 +122,7 @@ class TruncatedGaussianCorrectionFunctions
         $vt = self::vWithinMargin($teamPerformanceDifferenceAbsoluteValue, $drawMargin);
 
         return $vt * $vt +
-        (
+        (($drawMargin - $teamPerformanceDifferenceAbsoluteValue)
-            ($drawMargin - $teamPerformanceDifferenceAbsoluteValue)
             *
             GaussianDistribution::at(
                 $drawMargin - $teamPerformanceDifferenceAbsoluteValue

src/TrueSkill/TwoPlayerTrueSkillCalculator.php

@@ -37,7 +37,8 @@ class TwoPlayerTrueSkillCalculator extends SkillCalculator
         GameInfo $gameInfo,
         array $teams,
         array $teamRanks
-    ): RatingContainer {
+    ): RatingContainer
+    {
         // Basic argument checking
         Guard::argumentNotNull($gameInfo, 'gameInfo');
         $this->validateTeamCountAndPlayersCountPerTeam($teams);

src/TrueSkill/TwoTeamTrueSkillCalculator.php

@@ -70,7 +70,8 @@ class TwoTeamTrueSkillCalculator extends SkillCalculator
         Team $selfTeam,
         Team $otherTeam,
         PairwiseComparison $selfToOtherTeamComparison
-    ): void {
+    ): void
+    {
         $drawMargin = DrawMargin::getDrawMarginFromDrawProbability(
             $gameInfo->getDrawProbability(),
             $gameInfo->getBeta()