jct/trueskill
1
0
Fork 0
mirror of https://github.com/furyfire/trueskill.git synced 2025-04-19 20:34:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

More type work

Browse Source
This commit is contained in:
Jens True
2023-08-02 09:36:44 +00:00
parent 16ad8175d9
commit a60187a3fd
14 changed files with 38 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/TrueSkill/Factors/GaussianLikelihoodFactor.php
View File

@ -15,9 +15,9 @@ use Exception;
*/
class GaussianLikelihoodFactor extends GaussianFactor
{
private $precision;
private float $precision;
public function __construct($betaSquared, Variable $variable1, Variable $variable2)
public function __construct(float $betaSquared, Variable $variable1, Variable $variable2)
{
parent::__construct(sprintf('Likelihood of %s going to %s', $variable2, $variable1));
$this->precision = 1.0 / $betaSquared;
@ -42,7 +42,7 @@ class GaussianLikelihoodFactor extends GaussianFactor
);
}
private function updateHelper(Message $message1, Message $message2, Variable $variable1, Variable $variable2)
private function updateHelper(Message $message1, Message $message2, Variable $variable1, Variable $variable2): float
{
$message1Value = clone $message1->getValue();
$message2Value = clone $message2->getValue();
@ -70,7 +70,7 @@ class GaussianLikelihoodFactor extends GaussianFactor
return GaussianDistribution::subtract($newMarginal, $marginal1);
}
public function updateMessageIndex($messageIndex)
public function updateMessageIndex($messageIndex): float
{
$messages = $this->getMessages();
$vars = $this->getVariables();

8
src/TrueSkill/Factors/GaussianWithinFactor.php
View File

@ -14,16 +14,16 @@ use DNW\Skills\TrueSkill\TruncatedGaussianCorrectionFunctions;
*/
class GaussianWithinFactor extends GaussianFactor
{
private $epsilon;
private float $epsilon;
public function __construct($epsilon, Variable $variable)
public function __construct(float $epsilon, Variable $variable)
{
parent::__construct(sprintf('%s <= %.2f', $variable, $epsilon));
$this->epsilon = $epsilon;
$this->createVariableToMessageBinding($variable);
}
public function getLogNormalization()
public function getLogNormalization(): float
{
/**
* @var Variable[] $variables
@ -46,7 +46,7 @@ class GaussianWithinFactor extends GaussianFactor
return -GaussianDistribution::logProductNormalization($messageFromVariable, $message) + log($z);
}
protected function updateMessageVariable(Message $message, Variable $variable)
protected function updateMessageVariable(Message $message, Variable $variable): float
{
$oldMarginal = clone $variable->getValue();
$oldMessage = clone $message->getValue();