PHPstan on test code

This commit is contained in:
Jens True 2023-08-04 07:03:28 +00:00
parent ed665e755c
commit 9acc3bbeab
5 changed files with 6 additions and 6 deletions

@ -31,7 +31,7 @@
"@analyze-phpcs", "@analyze-phpcs",
"@analyze-psalm" "@analyze-psalm"
], ],
"analyze-phpstan":"vendor/bin/phpstan analyze --error-format=raw src/", "analyze-phpstan":"vendor/bin/phpstan analyze --error-format=raw",
"analyze-phpcs": "vendor/bin/phpcs --report=emacs --standard=PSR12 --exclude=Generic.Files.LineLength src", "analyze-phpcs": "vendor/bin/phpcs --report=emacs --standard=PSR12 --exclude=Generic.Files.LineLength src",
"analyze-psalm": "vendor/bin/psalm" "analyze-psalm": "vendor/bin/psalm"
} }

@ -2,4 +2,4 @@ parameters:
level: 6 level: 6
paths: paths:
- src - src
# - tests - tests

@ -6,7 +6,7 @@ use DNW\Skills\RankSorter;
class RankSorterTest extends TestCase class RankSorterTest extends TestCase
{ {
public function testSort() public function testSort(): void
{ {
$team1 = ['a' => 1, 'b' => 2]; $team1 = ['a' => 1, 'b' => 2];
$team2 = ['c' => 3, 'd' => 4]; $team2 = ['c' => 3, 'd' => 4];

@ -18,7 +18,7 @@ class DrawMarginTest extends TestCase
$this->assertDrawMargin(0.33, $beta, 2.5111010132487492); $this->assertDrawMargin(0.33, $beta, 2.5111010132487492);
} }
private function assertDrawMargin($drawProbability, $beta, $expected): void private function assertDrawMargin(float $drawProbability, float $beta, float $expected): void
{ {
$actual = DrawMargin::getDrawMarginFromDrawProbability($drawProbability, $beta); $actual = DrawMargin::getDrawMarginFromDrawProbability($drawProbability, $beta);
$this->assertEqualsWithDelta($expected, $actual, DrawMarginTest::ERROR_TOLERANCE); $this->assertEqualsWithDelta($expected, $actual, DrawMarginTest::ERROR_TOLERANCE);

@ -986,13 +986,13 @@ class TrueSkillCalculatorTests
self::assertMatchQuality($testClass, 0.44721358745011336, $matchQuality); self::assertMatchQuality($testClass, 0.44721358745011336, $matchQuality);
} }
private static function assertRating(TestCase $testClass, $expectedMean, $expectedStandardDeviation, $actual): void private static function assertRating(TestCase $testClass, float $expectedMean, float $expectedStandardDeviation, Rating $actual): void
{ {
$testClass->assertEqualsWithDelta($expectedMean, $actual->getMean(), self::ERROR_TOLERANCE_TRUESKILL); $testClass->assertEqualsWithDelta($expectedMean, $actual->getMean(), self::ERROR_TOLERANCE_TRUESKILL);
$testClass->assertEqualsWithDelta($expectedStandardDeviation, $actual->getStandardDeviation(), self::ERROR_TOLERANCE_TRUESKILL); $testClass->assertEqualsWithDelta($expectedStandardDeviation, $actual->getStandardDeviation(), self::ERROR_TOLERANCE_TRUESKILL);
} }
private static function assertMatchQuality(TestCase $testClass, $expectedMatchQuality, $actualMatchQuality): void private static function assertMatchQuality(TestCase $testClass, float $expectedMatchQuality, float $actualMatchQuality): void
{ {
$testClass->assertEqualsWithDelta($expectedMatchQuality, $actualMatchQuality, self::ERROR_TOLERANCE_MATCH_QUALITY); $testClass->assertEqualsWithDelta($expectedMatchQuality, $actualMatchQuality, self::ERROR_TOLERANCE_MATCH_QUALITY);
} }