jct/trueskill
1
0
Fork 0
mirror of https://github.com/furyfire/trueskill.git synced 2025-11-04 10:12:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Start of journey to actually give real names to factor graph variables using more PHP style

Browse Source
This commit is contained in:
Jeff Moser
2010-09-26 21:43:17 -04:00
parent f0f0ab7761
commit 5cb1919c21
6 changed files with 53 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
PHPSkills/FactorGraphs/VariableFactory.php
View File

@@ -14,17 +14,17 @@ class VariableFactory
$this->_variablePriorInitializer = &$variablePriorInitializer;
}
public function createBasicVariable()
public function createBasicVariable($name)
{
$initializer = $this->_variablePriorInitializer;
$newVar = new Variable("variable", $initializer());
$newVar = new Variable($name, $initializer());
return $newVar;
}
public function createKeyedVariable($key)
public function createKeyedVariable($key, $name)
{
$initializer = $this->_variablePriorInitializer;
$newVar = new KeyedVariable($key, "key variable", $initializer());
$newVar = new KeyedVariable($key, $name, $initializer());
return $newVar;
}
}

2
PHPSkills/Player.php
View File

@@ -71,7 +71,7 @@ class Player implements ISupportPartialPlay, ISupportPartialUpdate
{
if ($this->_Id != null)
{
return $this->_Id;
return (string)$this->_Id;
}
return parent::__toString();

39
PHPSkills/TrueSkill/Factors/GaussianWeightedSumFactor.php
View File

@@ -227,9 +227,44 @@ class GaussianWeightedSumFactor extends GaussianFactor
$updatedVariables);
}
private static function createName($sumVariable, $variablesToSum, $variableWeights)
private static function createName($sumVariable, $variablesToSum, $weights)
{
return "TODO";
// TODO: Perf? Use PHP equivalent of StringBuilder? implode on arrays?
$result = (string)$sumVariable;
$result .= ' = ';
$totalVars = count($variablesToSum);
for($i = 0; $i < $totalVars; $i++)
{
$isFirst = ($i == 0);
if($isFirst && ($weights[$i] < 0))
{
$result .= '-';
}
$absValue = sprintf("%.2f", \abs($weights[$i])); // 0.00?
$result .= $absValue;
$result .= "*[";
$result .= (string)$variablesToSum[$i];
$result .= ']';
$isLast = ($i == ($totalVars - 1));
if(!$isLast)
{
if($weights[$i + 1] >= 0)
{
$result .= ' + ';
}
else
{
$result .= ' - ';
}
}
}
return $result;
}
}

13
PHPSkills/TrueSkill/Layers/PlayerPerformancesToTeamPerformancesLayer.php
View File

@@ -27,7 +27,7 @@ class PlayerPerformancesToTeamPerformancesLayer extends TrueSkillFactorGraphLaye
{
foreach ($this->getInputVariablesGroups() as $currentTeam)
{
$teamPerformance = &$this->createOutputVariable($currentTeam);
$teamPerformance = $this->createOutputVariable($currentTeam);
$newSumFactor = $this->createPlayerToTeamSumFactor($currentTeam, $teamPerformance);
$this->addLayerFactor($newSumFactor);
@@ -83,9 +83,14 @@ class PlayerPerformancesToTeamPerformancesLayer extends TrueSkillFactorGraphLaye
private function createOutputVariable(&$team)
{
///$teamMemberNames = String.Join(", ", team.Select(teamMember => teamMember.Key.ToString()).ToArray());
$teamMemberNames = "TODO";
return $this->getParentFactorGraph()->getVariableFactory()->createBasicVariable("Team[{0}]'s performance", $teamMemberNames);
$memberNames = \array_map(function ($currentPlayer)
{
return (string)($currentPlayer->getKey());
},
$team);
$teamMemberNames = \join(", ", $memberNames);
return $this->getParentFactorGraph()->getVariableFactory()->createBasicVariable("Team[" . $teamMemberNames . "]'s performance");
}
}

2
PHPSkills/TrueSkill/Layers/PlayerPriorValuesToSkillsLayer.php
View File

@@ -69,7 +69,7 @@ class PlayerPriorValuesToSkillsLayer extends TrueSkillFactorGraphLayer
{
$parentFactorGraph = $this->getParentFactorGraph();
$variableFactory = $parentFactorGraph->getVariableFactory();
return $variableFactory->createKeyedVariable($key, "{0}'s skill", $key);
return $variableFactory->createKeyedVariable($key, $key . "'s skill");
}
}

2
PHPSkills/TrueSkill/Layers/PlayerSkillsToPerformancesLayer.php
View File

@@ -44,7 +44,7 @@ class PlayerSkillsToPerformancesLayer extends TrueSkillFactorGraphLayer
private function createOutputVariable(&$key)
{
return $this->getParentFactorGraph()->getVariableFactory()->createKeyedVariable($key, "{0}'s performance", $key);
return $this->getParentFactorGraph()->getVariableFactory()->createKeyedVariable($key, $key . "'s performance");
}
public function createPriorSchedule()