jct/trueskill
1
0
Fork 0
mirror of https://github.com/furyfire/trueskill.git synced 2025-11-04 02:02:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Optimization efforts

Browse Source
This commit is contained in:
Jens True
2024-02-15 09:08:01 +00:00
parent b966a930a4
commit 5bebd9310d
6 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Numerics/BasicMath.php
View File

@@ -15,11 +15,11 @@ class BasicMath
/**
* Squares the input (x^2 = x * x)
*
* @param float $x Value to square (x)
* @param $x Value to square (x)
*
* @return float The squared value (x^2)
*/
public static function square($x): float
public static function square(float $x): float
{
return $x * $x;
}

8
src/Numerics/DiagonalMatrix.php
View File

@@ -12,13 +12,11 @@ class DiagonalMatrix extends Matrix
public function __construct(array $diagonalValues)
{
$diagonalCount = count($diagonalValues);
$rowCount = $diagonalCount;
$colCount = $rowCount;
parent::__construct($rowCount, $colCount);
parent::__construct($diagonalCount, $diagonalCount);
for ($currentRow = 0; $currentRow < $rowCount; $currentRow++) {
for ($currentCol = 0; $currentCol < $colCount; $currentCol++) {
for ($currentRow = 0; $currentRow < $diagonalCount; $currentRow++) {
for ($currentCol = 0; $currentCol < $diagonalCount; $currentCol++) {
if ($currentRow === $currentCol) {
$this->setValue($currentRow, $currentCol, $diagonalValues[$currentRow]);
} else {

9
src/Numerics/SquareMatrix.php
View File

@@ -8,18 +8,17 @@ class SquareMatrix extends Matrix
{
public function __construct(float|int ...$allValues)
{
$rows = (int)sqrt(count($allValues));
$cols = $rows;
$size = (int)sqrt(count($allValues));
$matrixData = [];
$allValuesIndex = 0;
for ($currentRow = 0; $currentRow < $rows; $currentRow++) {
for ($currentColumn = 0; $currentColumn < $cols; $currentColumn++) {
for ($currentRow = 0; $currentRow < $size; $currentRow++) {
for ($currentColumn = 0; $currentColumn < $size; $currentColumn++) {
$matrixData[$currentRow][$currentColumn] = $allValues[$allValuesIndex++];
}
}
parent::__construct($rows, $cols, $matrixData);
parent::__construct($size, $size, $matrixData);
}
}

1
src/TrueSkill/Factors/GaussianWeightedSumFactor.php
View File

@@ -181,7 +181,6 @@ class GaussianWeightedSumFactor extends GaussianFactor
}
$newPrecision = 1.0 / $inverseOfNewPrecisionSum;
$anotherNewPrecision = 1.0 / $anotherInverseOfNewPrecisionSum;
$newPrecisionMean = $newPrecision * $weightedMeanSum;