jct/trueskill
1
0
Fork 0
mirror of https://github.com/furyfire/trueskill.git synced 2025-04-18 20:04:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

More return types. Basic example

Browse Source
This commit is contained in:
Jens True
2023-08-02 09:04:56 +00:00
parent f0aa9413e1
commit 32b8a9d83e
13 changed files with 71 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/TrueSkill/Factors/GaussianPriorFactor.php
View File

@ -13,7 +13,7 @@ use DNW\Skills\Numerics\GaussianDistribution;
*/
class GaussianPriorFactor extends GaussianFactor
{
private $newMessage;
private GaussianDistribution $newMessage;
public function __construct(float $mean, float $variance, Variable $variable)
{

4
src/TrueSkill/Factors/GaussianWeightedSumFactor.php
View File

@ -11,7 +11,7 @@ use DNW\Skills\Numerics\GaussianDistribution;
/**
* Factor that sums together multiple Gaussians.
*
* See the accompanying math paper for more details.s
* See the accompanying math paper for more details.
*/
class GaussianWeightedSumFactor extends GaussianFactor
{
@ -213,7 +213,7 @@ class GaussianWeightedSumFactor extends GaussianFactor
);
}
private static function createName($sumVariable, $variablesToSum, $weights)
private static function createName(string $sumVariable, array $variablesToSum, array $weights): string
{
// TODO: Perf? Use PHP equivalent of StringBuilder? implode on arrays?
$result = (string) $sumVariable;

2
src/TrueSkill/Layers/PlayerSkillsToPerformancesLayer.php
View File

@ -10,7 +10,7 @@ use DNW\Skills\FactorGraphs\ScheduleSequence;
class PlayerSkillsToPerformancesLayer extends TrueSkillFactorGraphLayer
{
public function buildLayer()
public function buildLayer(): void
{
$inputVariablesGroups = $this->getInputVariablesGroups();
$outputVariablesGroups = &$this->getOutputVariablesGroups();

4
src/TrueSkill/Layers/TeamDifferencesComparisonLayer.php
View File

@ -9,7 +9,7 @@ use DNW\Skills\TrueSkill\TrueSkillFactorGraph;
class TeamDifferencesComparisonLayer extends TrueSkillFactorGraphLayer
{
private $epsilon;
private float $epsilon;
public function __construct(TrueSkillFactorGraph $parentGraph, private readonly array $teamRanks)
{
@ -18,7 +18,7 @@ class TeamDifferencesComparisonLayer extends TrueSkillFactorGraphLayer
$this->epsilon = DrawMargin::getDrawMarginFromDrawProbability($gameInfo->getDrawProbability(), $gameInfo->getBeta());
}
public function buildLayer()
public function buildLayer(): void
{
$inputVarGroups = $this->getInputVariablesGroups();
$inputVarGroupsCount = is_countable($inputVarGroups) ? count($inputVarGroups) : 0;

2
src/TrueSkill/TwoPlayerTrueSkillCalculator.php
View File

@ -78,7 +78,7 @@ class TwoPlayerTrueSkillCalculator extends SkillCalculator
return $results;
}
private static function calculateNewRating(GameInfo $gameInfo, Rating $selfRating, Rating $opponentRating, $comparison)
private static function calculateNewRating(GameInfo $gameInfo, Rating $selfRating, Rating $opponentRating, $comparison): Rating
{
$drawMargin = DrawMargin::getDrawMarginFromDrawProbability(
$gameInfo->getDrawProbability(),