mirror of
				https://github.com/furyfire/trueskill.git
				synced 2025-11-04 10:12:28 +01:00 
			
		
		
		
	Fixed factor list probability of ranking error due to missing factors from the iterated layer
This commit is contained in:
		@@ -52,10 +52,7 @@ class FactorGraphTrueSkillCalculator extends SkillCalculator
 | 
			
		||||
        $factorGraph = new TrueSkillFactorGraph($gameInfo, $teams, $teamRanks);
 | 
			
		||||
        $factorGraph->buildGraph();
 | 
			
		||||
        $factorGraph->runSchedule();
 | 
			
		||||
 | 
			
		||||
        $test = $factorGraph->getUpdatedRatings();
 | 
			
		||||
 | 
			
		||||
        // DEBUG: Fix this :)
 | 
			
		||||
        
 | 
			
		||||
        $probabilityOfOutcome = $factorGraph->getProbabilityOfRanking();
 | 
			
		||||
 | 
			
		||||
        return $factorGraph->getUpdatedRatings();
 | 
			
		||||
 
 | 
			
		||||
@@ -27,6 +27,14 @@ class IteratedTeamDifferencesInnerLayer extends TrueSkillFactorGraphLayer
 | 
			
		||||
        $this->_TeamDifferencesComparisonLayer = $teamDifferencesComparisonLayer;
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    public function &getLocalFactors()
 | 
			
		||||
    {
 | 
			
		||||
        $localFactors =
 | 
			
		||||
            \array_merge($this->_TeamPerformancesToTeamPerformanceDifferencesLayer->getLocalFactors(),
 | 
			
		||||
                         $this->_TeamDifferencesComparisonLayer->getLocalFactors());
 | 
			
		||||
        return $localFactors;
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    public function buildLayer()
 | 
			
		||||
    {
 | 
			
		||||
        $inputVariablesGroups = &$this->getInputVariablesGroups();
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user