Modernizing code. Bit more OO design than previously.

lib/CommandHandler/CommandHandler.cpp

@@ -8,7 +8,7 @@ CommandHandler::CommandHandler(DisplayProxy *display)
     this->display = display;
 }
 
-bool CommandHandler::parse(char *cmd)
+bool CommandHandler::parse(const char *cmd)
 {
     Serial.print("Handling: ");
     Serial.println(cmd);

lib/CommandHandler/CommandHandler.h

@@ -5,8 +5,8 @@
 class CommandHandler
 {
 public:
-    CommandHandler(DisplayProxy *display);
-    bool parse(char *cmd);
+    explicit CommandHandler(DisplayProxy *display);
+    bool parse(const char *cmd);
 private:
     void debugWrite(int x, int y, const char *text);
     DisplayProxy *display;

lib/DisplayProxy/DisplayProxyMAX7456.cpp

@@ -3,22 +3,54 @@
 DisplayProxyMAX7456::DisplayProxyMAX7456(Max7456 *osd)
 {
     this->osd = osd;
+    this->osd->init(6);
+    clear();
+    this->osd->setBlinkParams(_8fields, _BT_3BT);
+
+    externalVideo(false);
+    onScreenDisplay(true);
 }
 
+/**
+ * Write a text string to the display at the given position
+ * @param x Position along the X axis
+ * @param y Position along the Y axis
+ * @param text The string to print
+ * @return Success or false
+ */
 bool DisplayProxyMAX7456::write(int x, int y, const char *text)
 {
     this->osd->print(text, x, y);
     return true;
 }
 
+/**
+ * Clear the entire screen
+ */
 bool DisplayProxyMAX7456::clear()
 {
     this->osd->clearScreen();
     return true;
 }
 
+/**
+ * Adjust the display offset.
+ * Since the signal is analog the characters might be rendered outside the display area
+ */
 bool DisplayProxyMAX7456::setOffset(int x, int y)
 {
     this->osd->setDisplayOffsets(x, y);
     return true;
+}
+
+bool DisplayProxyMAX7456::externalVideo(bool enabled)
+{
+    this->osd->activateExternalVideo(enabled);
+    return true;
+}
+
+bool DisplayProxyMAX7456::onScreenDisplay(bool enabled) 
+{
+    this->osd->activateOSD(enabled);
+    return true;
 }

lib/DisplayProxy/DisplayProxyMAX7456.h

@@ -7,11 +7,14 @@
 class DisplayProxyMAX7456 : public DisplayProxy
 {
 public:
-    DisplayProxyMAX7456(Max7456 *osd);
+    explicit DisplayProxyMAX7456(Max7456 *osd);
+
+    bool write(int x, int y, const char *text) override;
+    bool clear() override;
+    bool setOffset(int x, int y) override;
+    bool externalVideo(bool enabled);
+    bool onScreenDisplay(bool enabled);
 
-    bool write(int x, int y, const char *text);
-    bool clear() ;
-    bool setOffset(int x, int y);
 private:
     Max7456 *osd;
 };